fix(cosmrs): BodyBuilder non-critical extension add
#516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-iqlusion
approved these changes
Feb 1, 2025
|
Thank you for the quick merge @tony-iqlusion 🙏. Can a release be done for this? Thanks! :) |
|
Yes, give me a few days |
Merged
v0-e
added a commit
to dydxprotocol/v4-clients
that referenced
this pull request
Mar 5, 2025
Permissionless key implementation. Interface for the permissioning account is through `NodeClient::authenticators()` for gRPC requests. Interface for the permissioned account is through `Account::authenticators()`. Closes #318. Had to increase fee adjustment multiplier a bit (from `1.4` to `1.8`). While the TS client has it at `1.6`, some transactions were being rejected at this value here. Issue #320 may be related. (edit: ready) Awaiting on a `cosmrs` release which fixes a [small issue](cosmos/cosmos-rust#516) related with non-critical Tx extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes adding a non-critical extension to the internal non-critical extension vector instead of to the extension vector.